From 05d79890d437b662a9c08a52ea6121867426014b Mon Sep 17 00:00:00 2001 From: Apostolof Date: Tue, 4 Sep 2018 02:43:39 +0300 Subject: [PATCH] Add filename field, fixes --- .../activities/upload/UploadActivity.java | 177 +++++++++++++----- .../activities/upload/UploadsHelper.java | 2 +- .../drawable/ic_attach_file_white_24dp.xml | 4 - .../drawable/ic_info_outline_warning_24dp.xml | 4 + app/src/main/res/layout/activity_upload.xml | 43 +++-- .../activity_upload_filename_info_popup.xml | 9 + app/src/main/res/values/strings.xml | 4 +- 7 files changed, 174 insertions(+), 69 deletions(-) delete mode 100644 app/src/main/res/drawable/ic_attach_file_white_24dp.xml create mode 100644 app/src/main/res/drawable/ic_info_outline_warning_24dp.xml create mode 100644 app/src/main/res/layout/activity_upload_filename_info_popup.xml diff --git a/app/src/main/java/gr/thmmy/mthmmy/activities/upload/UploadActivity.java b/app/src/main/java/gr/thmmy/mthmmy/activities/upload/UploadActivity.java index 1a0be773..6da4a8bd 100644 --- a/app/src/main/java/gr/thmmy/mthmmy/activities/upload/UploadActivity.java +++ b/app/src/main/java/gr/thmmy/mthmmy/activities/upload/UploadActivity.java @@ -5,32 +5,31 @@ import android.content.Context; import android.content.Intent; import android.content.SharedPreferences; import android.content.pm.PackageManager; -import android.database.Cursor; import android.graphics.drawable.Drawable; import android.net.Uri; import android.os.AsyncTask; import android.os.Bundle; -import android.os.Environment; -import android.provider.OpenableColumns; import android.support.annotation.NonNull; import android.support.design.widget.FloatingActionButton; import android.support.v4.content.FileProvider; import android.support.v7.content.res.AppCompatResources; import android.support.v7.preference.PreferenceManager; import android.support.v7.widget.AppCompatButton; -import android.support.v7.widget.AppCompatTextView; -import android.util.Log; +import android.support.v7.widget.AppCompatImageButton; +import android.text.Editable; +import android.text.TextWatcher; +import android.text.method.LinkMovementMethod; +import android.view.LayoutInflater; import android.view.View; import android.widget.AdapterView; import android.widget.ArrayAdapter; import android.widget.EditText; import android.widget.LinearLayout; +import android.widget.PopupWindow; import android.widget.ProgressBar; +import android.widget.TextView; import android.widget.Toast; - -import com.snatik.storage.Storage; - import net.gotev.uploadservice.MultipartUploadRequest; import net.gotev.uploadservice.ServerResponse; import net.gotev.uploadservice.UploadInfo; @@ -86,7 +85,6 @@ public class UploadActivity extends BaseActivity { private static final int SELECT_FILE_METHOD_SELECTED = 1; private static final int TAKE_PHOTO_METHOD_SELECTED = 2; - private static final String TEMPORARY_FILES_DIRECTORY = "~tmp_mThmmy_uploads"; private static final int MAX_FILE_SIZE_SUPPORTED = 45000000; private ArrayList uploadRootCategories = new ArrayList<>(); @@ -100,16 +98,15 @@ public class UploadActivity extends BaseActivity { private File photoFileSelected = null; private File photoFileCreated = null; private String fileIcon; - private String generatorUploadFilename; //UI elements private MaterialProgressBar progressBar; private LinearLayout categoriesSpinners; private AppCompatSpinnerWithoutDefault rootCategorySpinner; private EditText uploadTitle; + private EditText uploadFilename; private EditText uploadDescription; private AppCompatButton titleDescriptionBuilderButton; - private AppCompatTextView filenameHolder; @Override protected void onCreate(Bundle savedInstanceState) { @@ -215,9 +212,50 @@ public class UploadActivity extends BaseActivity { uploadTitle = findViewById(R.id.upload_title); uploadDescription = findViewById(R.id.upload_description); - filenameHolder = findViewById(R.id.upload_filename); - Drawable filenameDrawable = AppCompatResources.getDrawable(this, R.drawable.ic_attach_file_white_24dp); - filenameHolder.setCompoundDrawablesRelativeWithIntrinsicBounds(filenameDrawable, null, null, null); + AppCompatImageButton uploadFilenameInfo = findViewById(R.id.upload_filename_info); + uploadFilenameInfo.setOnClickListener(view -> { + //Inflates the popup menu content + LayoutInflater layoutInflater = (LayoutInflater) view.getContext(). + getSystemService(Context.LAYOUT_INFLATER_SERVICE); + if (layoutInflater == null) { + return; + } + View popUpContent = layoutInflater.inflate(R.layout.activity_upload_filename_info_popup, null); + + //Creates the PopupWindow + PopupWindow popUp = new PopupWindow(view.getContext()); + popUp.setContentView(popUpContent); + popUp.setWidth(LinearLayout.LayoutParams.WRAP_CONTENT); + popUp.setHeight(LinearLayout.LayoutParams.WRAP_CONTENT); + popUp.setFocusable(true); + + //((TextView) popUpContent.findViewById(R.id.upload_filename_info_text)).setTe + ((TextView) popUpContent.findViewById(R.id.upload_filename_info_text)). + setMovementMethod(LinkMovementMethod.getInstance()); + //Displays the popup + popUp.showAsDropDown(view); + }); + + uploadFilename = findViewById(R.id.upload_filename); + uploadFilename.addTextChangedListener(new TextWatcher() { + @Override + public void beforeTextChanged(CharSequence s, int start, int count, int after) { + } + + @Override + public void onTextChanged(CharSequence s, int start, int before, int count) { + } + + @Override + public void afterTextChanged(Editable s) { + if (!s.toString().isEmpty() && + !s.toString().matches("[0-9a-zA-Z~!@#$%^&()_+=\\-`\\[\\]{};',.]+")) { + uploadFilenameInfo.setImageResource(R.drawable.ic_info_outline_warning_24dp); + } else { + uploadFilenameInfo.setImageResource(R.drawable.ic_info_outline_white_24dp); + } + } + }); AppCompatButton selectFileButton = findViewById(R.id.upload_select_file_button); Drawable selectStartDrawable = AppCompatResources.getDrawable(this, R.drawable.ic_insert_drive_file_white_24dp); @@ -268,7 +306,7 @@ public class UploadActivity extends BaseActivity { Toast.makeText(view.getContext(), "Please choose category first", Toast.LENGTH_SHORT).show(); shouldReturn = true; } - if (UploadsHelper.sizeFromUri(this, fileUri) > MAX_FILE_SIZE_SUPPORTED) { + if (fileUri != null && UploadsHelper.sizeFromUri(this, fileUri) > MAX_FILE_SIZE_SUPPORTED) { Toast.makeText(view.getContext(), "Your files are too powerful for thmmy. Reduce size or split!", Toast.LENGTH_LONG).show(); shouldReturn = true; } @@ -284,35 +322,41 @@ public class UploadActivity extends BaseActivity { uploadDescriptionText += uploadedFromThmmyPromptHtml; } - //Checks if the generator was used - if (generatorUploadFilename != null) { - //File should be uploaded with a certain name. - switch (uploadMethodSelected) { - case SELECT_FILE_METHOD_SELECTED: - //Temporarily copies the file to a another location and renames it - fileUri = UploadsHelper.createTempFile(this, storage, fileUri, - generatorUploadFilename); - break; - case TAKE_PHOTO_METHOD_SELECTED: - //Renames the photo taken - String photoPath = photoFileSelected.getPath(); - photoPath = photoPath.substring(0, photoPath.lastIndexOf(File.separator)); - String destinationFilename = photoPath + File.separator + generatorUploadFilename + ".jpg"; - - if (!storage.rename(photoFileSelected.getAbsolutePath(), destinationFilename)) { - //Something went wrong, abort - Toast.makeText(this, "Could not create temporary file for renaming", Toast.LENGTH_SHORT).show(); - progressBar.setVisibility(View.GONE); - return; - } + //Checks if a file renaming is necessary + { + String editTextFilename = uploadFilename.getText().toString(); + String selectedFileFilename = UploadsHelper.filenameFromUri(this, fileUri); + selectedFileFilename = selectedFileFilename.substring(0, selectedFileFilename.indexOf(".")); + + if (!editTextFilename.equals(selectedFileFilename)) { + //File should be uploaded with a different name + switch (uploadMethodSelected) { + case SELECT_FILE_METHOD_SELECTED: + //Temporarily copies the file to a another location and renames it + fileUri = UploadsHelper.createTempFile(this, storage, fileUri, + editTextFilename); + break; + case TAKE_PHOTO_METHOD_SELECTED: + //Renames the photo taken + String photoPath = photoFileSelected.getPath(); + photoPath = photoPath.substring(0, photoPath.lastIndexOf(File.separator)); + String destinationFilename = photoPath + File.separator + editTextFilename + ".jpg"; + + if (!storage.rename(photoFileSelected.getAbsolutePath(), destinationFilename)) { + //Something went wrong, abort + Toast.makeText(this, "Could not create temporary file for renaming", Toast.LENGTH_SHORT).show(); + progressBar.setVisibility(View.GONE); + return; + } - //Points photoFile and fileUri to the new copied and renamed file - photoFileSelected = storage.getFile(destinationFilename); - fileUri = FileProvider.getUriForFile(this, getPackageName() + - ".provider", photoFileSelected); - break; - default: - break; + //Points photoFile and fileUri to the new copied and renamed file + photoFileSelected = storage.getFile(destinationFilename); + fileUri = FileProvider.getUriForFile(this, getPackageName() + + ".provider", photoFileSelected); + break; + default: + break; + } } } @@ -346,17 +390,15 @@ public class UploadActivity extends BaseActivity { UploadsHelper.deleteTempFiles(); BaseApplication.getInstance().logFirebaseAnalyticsEvent("file_upload", null); - if (uploadMethodSelected == TAKE_PHOTO_METHOD_SELECTED) { TakePhoto.galleryAddPic(context, photoFileSelected); } uploadTitle.setText(null); + uploadFilename.setText(null); uploadDescription.setText(null); fileUri = null; photoFileCreated = null; photoFileSelected = null; - filenameHolder.setText(null); - filenameHolder.setVisibility(View.GONE); progressBar.setVisibility(View.GONE); } @@ -423,6 +465,21 @@ public class UploadActivity extends BaseActivity { return; } + //Keeps the filename between different file selections if it has been modified + boolean hasCustomFilename = false; + { + String editTextFilename = uploadFilename.getText().toString(); + String previousFilename = ""; + if (fileUri != null) { + previousFilename = UploadsHelper.filenameFromUri(this, fileUri); + previousFilename = previousFilename.substring(0, previousFilename.indexOf(".")); + } + + if (!editTextFilename.isEmpty() && !editTextFilename.equals(previousFilename)) { + hasCustomFilename = true; + } + } + //Deletes any photo file previously created, as it is not going to be used if (photoFileCreated != null) { storage.deleteFile(photoFileCreated.getAbsolutePath()); @@ -435,8 +492,9 @@ public class UploadActivity extends BaseActivity { fileUri = data.getData(); if (fileUri != null) { String filename = UploadsHelper.filenameFromUri(this, fileUri); - filenameHolder.setText(filename); - filenameHolder.setVisibility(View.VISIBLE); + if (!hasCustomFilename) { + uploadFilename.setText(filename.substring(0, filename.indexOf("."))); + } filename = filename.toLowerCase(); if (filename.endsWith(".jpg")) { @@ -466,6 +524,21 @@ public class UploadActivity extends BaseActivity { } uploadMethodSelected = TAKE_PHOTO_METHOD_SELECTED; + //Keeps the filename between different file selections if it has been modified + boolean hasCustomFilename = false; + { + String editTextFilename = uploadFilename.getText().toString(); + String previousFilename = ""; + if (fileUri != null) { + previousFilename = UploadsHelper.filenameFromUri(this, fileUri); + previousFilename = previousFilename.substring(0, previousFilename.indexOf(".")); + } + + if (!editTextFilename.isEmpty() && !editTextFilename.equals(previousFilename)) { + hasCustomFilename = true; + } + } + if (photoFileSelected != null) { storage.deleteFile(photoFileSelected.getAbsolutePath()); } @@ -473,16 +546,18 @@ public class UploadActivity extends BaseActivity { fileUri = TakePhoto.processResult(this, photoFileSelected); - filenameHolder.setText(photoFileSelected.getName()); - filenameHolder.setVisibility(View.VISIBLE); + if (!hasCustomFilename) { + uploadFilename.setText(photoFileSelected.getName(). + substring(0, photoFileSelected.getName().indexOf("."))); + } fileIcon = "jpg_image.gif"; } else if (requestCode == AFR_REQUEST_CODE_FIELDS_BUILDER) { if (resultCode == Activity.RESULT_CANCELED) { return; } - generatorUploadFilename = data.getStringExtra(RESULT_FILENAME); uploadTitle.setText(data.getStringExtra(RESULT_TITLE)); + uploadFilename.setText(data.getStringExtra(RESULT_FILENAME)); uploadDescription.setText(data.getStringExtra(RESULT_DESCRIPTION)); } else { super.onActivityResult(requestCode, resultCode, data); diff --git a/app/src/main/java/gr/thmmy/mthmmy/activities/upload/UploadsHelper.java b/app/src/main/java/gr/thmmy/mthmmy/activities/upload/UploadsHelper.java index f8724a89..5ad0f8fe 100644 --- a/app/src/main/java/gr/thmmy/mthmmy/activities/upload/UploadsHelper.java +++ b/app/src/main/java/gr/thmmy/mthmmy/activities/upload/UploadsHelper.java @@ -95,7 +95,7 @@ class UploadsHelper { return filename; } - static long sizeFromUri(Context context, Uri uri){ + static long sizeFromUri(Context context, @NonNull Uri uri){ try (Cursor cursor = context.getContentResolver().query(uri, null, null, null, null)) { if (cursor != null && cursor.moveToFirst()) { return cursor.getLong(cursor.getColumnIndex(OpenableColumns.SIZE)); diff --git a/app/src/main/res/drawable/ic_attach_file_white_24dp.xml b/app/src/main/res/drawable/ic_attach_file_white_24dp.xml deleted file mode 100644 index 4834305b..00000000 --- a/app/src/main/res/drawable/ic_attach_file_white_24dp.xml +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/app/src/main/res/drawable/ic_info_outline_warning_24dp.xml b/app/src/main/res/drawable/ic_info_outline_warning_24dp.xml new file mode 100644 index 00000000..1c3b206c --- /dev/null +++ b/app/src/main/res/drawable/ic_info_outline_warning_24dp.xml @@ -0,0 +1,4 @@ + + + + diff --git a/app/src/main/res/layout/activity_upload.xml b/app/src/main/res/layout/activity_upload.xml index d2f81b4c..21dfeb54 100644 --- a/app/src/main/res/layout/activity_upload.xml +++ b/app/src/main/res/layout/activity_upload.xml @@ -45,6 +45,7 @@ android:id="@+id/upload_spinners" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginTop="8dp" android:background="@color/background" android:orientation="vertical"> @@ -73,6 +74,36 @@ android:maxLength="500" /> + + + + + + + + + + - - diff --git a/app/src/main/res/layout/activity_upload_filename_info_popup.xml b/app/src/main/res/layout/activity_upload_filename_info_popup.xml new file mode 100644 index 00000000..8b31440c --- /dev/null +++ b/app/src/main/res/layout/activity_upload_filename_info_popup.xml @@ -0,0 +1,9 @@ + + \ No newline at end of file diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 4b8013a4..d941c819 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -114,12 +114,14 @@ Upload - Generate title and description + Generate fields Title + Upload as (filename) Description Select file Take photo Select a category + Please follow the filename rules described in this topic. Select type of upload