Minor bookmarks activity UI enhancements

app/src/main/java/gr/thmmy/mthmmy/activities/bookmarks/BoardBookmarksFragment.java

@@ -73,7 +73,7 @@ public class BoardBookmarksFragment extends Fragment {
             for (final Bookmark bookmarkedBoard : boardBookmarks) {
                 if (bookmarkedBoard != null && bookmarkedBoard.getTitle() != null) {
                     final LinearLayout row = (LinearLayout) layoutInflater.inflate(
-                            R.layout.activity_bookmark_board_row, bookmarksLinearView, false);
+                            R.layout.fragment_bookmarks_board_row, bookmarksLinearView, false);
                     row.setOnClickListener(new View.OnClickListener() {
                         @Override
                         public void onClick(View view) {

app/src/main/java/gr/thmmy/mthmmy/activities/bookmarks/TopicBookmarksFragment.java

@@ -87,7 +87,7 @@ public class TopicBookmarksFragment extends Fragment {
             for (final Bookmark bookmarkedTopic : topicBookmarks) {
                 if (bookmarkedTopic != null && bookmarkedTopic.getTitle() != null) {
                     final LinearLayout row = (LinearLayout) layoutInflater.inflate(
-                            R.layout.activity_bookmark_topic_row, bookmarksLinearView, false);
+                            R.layout.fragment_bookmarks_topic_row, bookmarksLinearView, false);
                     row.setOnClickListener(new View.OnClickListener() {
                         @Override
                         public void onClick(View view) {

app/src/main/res/layout/fragment_bookmarks.xml

@@ -17,6 +17,9 @@
             android:id="@+id/bookmarks_container"
             android:layout_width="match_parent"
             android:layout_height="match_parent"
-            android:orientation="vertical"/>
+            android:orientation="vertical"
+            android:showDividers="middle"
+            android:divider="?android:listDivider"
+            android:dividerPadding="16dp"/>
     </android.support.v4.widget.NestedScrollView>
 </RelativeLayout>

app/src/main/res/layout/activity_bookmark_board_row.xml → app/src/main/res/layout/fragment_bookmarks_board_row.xml

@@ -8,26 +8,30 @@
     android:clickable="true"
     android:focusable="true"
     android:gravity="center_vertical"
-    android:orientation="horizontal"
+    android:orientation="horizontal">
-    android:paddingBottom="6dp"
-    android:paddingEnd="16dp"
-    android:paddingStart="16dp"
-    android:paddingTop="6dp">
 
     <TextView
         android:id="@+id/bookmark_title"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_weight="1"
-        android:paddingBottom="2dp"
+        android:paddingBottom="8dp"
+        android:paddingTop="6dp"
+        android:paddingStart="16dp"
+        android:paddingEnd="0dp"
         android:textColor="@color/primary_text"
         android:textSize="18sp"/>
 
     <ImageButton
         android:id="@+id/remove_bookmark"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_height="match_parent"
+        android:paddingBottom="3dp"
+        android:paddingTop="3dp"
+        android:paddingStart="6dp"
+        android:paddingEnd="6dp"
+        android:layout_marginEnd="12dp"
         android:background="?android:attr/selectableItemBackground"
         android:contentDescription="@string/remove_bookmark"
-        android:src="@drawable/ic_remove_circle"/>
+        android:src="@drawable/ic_delete"/>
 </LinearLayout>

app/src/main/res/layout/activity_bookmark_topic_row.xml → app/src/main/res/layout/fragment_bookmarks_topic_row.xml

@@ -9,26 +9,29 @@
     android:clickable="true"
     android:focusable="true"
     android:gravity="center_vertical"
-    android:orientation="horizontal"
+    android:orientation="horizontal">
-    android:paddingBottom="6dp"
-    android:paddingEnd="16dp"
-    android:paddingStart="16dp"
-    android:paddingTop="6dp">
 
     <TextView
         android:id="@+id/bookmark_title"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_weight="1"
-        android:paddingBottom="2dp"
+        android:paddingBottom="8dp"
+        android:paddingTop="6dp"
+        android:paddingStart="16dp"
+        android:paddingEnd="0dp"
         android:textColor="@color/primary_text"
         android:textSize="18sp"/>
 
     <ImageButton
         android:id="@+id/toggle_notification"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_height="match_parent"
-        android:layout_marginEnd="12dp"
+        android:paddingBottom="3dp"
+        android:paddingTop="3dp"
+        android:paddingStart="6dp"
+        android:paddingEnd="6dp"
+        android:layout_marginEnd="9dp"
         android:background="?android:attr/selectableItemBackground"
         android:contentDescription="@string/toggle_notification"
         app:srcCompat="@drawable/ic_notification_on"/>
@@ -36,8 +39,13 @@
     <ImageButton
         android:id="@+id/remove_bookmark"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_height="match_parent"
+        android:paddingBottom="3dp"
+        android:paddingTop="3dp"
+        android:paddingStart="6dp"
+        android:paddingEnd="6dp"
+        android:layout_marginEnd="12dp"
         android:background="?android:attr/selectableItemBackground"
         android:contentDescription="@string/remove_bookmark"
-        android:src="@drawable/ic_remove_circle"/>
+        android:src="@drawable/ic_delete"/>
 </LinearLayout>

app/src/main/res/values/strings.xml

@@ -100,7 +100,4 @@
     <string name="cancel">Cancel</string>
     <string name="open">Open</string>
     <string name="download">Download</string>
-
-    <!-- TODO: Remove or change this placeholder text -->
-    <string name="hello_blank_fragment">Hello blank fragment</string>
 </resources>