From 5737b69931b806d3daf902e55fe72bdd1c2a9011 Mon Sep 17 00:00:00 2001
From: Ezerous <ezerous@gmail.com>
Date: Mon, 7 Oct 2019 16:02:29 +0300
Subject: [PATCH] Tidy up long click copy topic url

---
 .../activities/topic/TopicActivity.java       | 68 ++++++-------------
 app/src/main/res/values/strings.xml           |  3 +-
 2 files changed, 21 insertions(+), 50 deletions(-)

diff --git a/app/src/main/java/gr/thmmy/mthmmy/activities/topic/TopicActivity.java b/app/src/main/java/gr/thmmy/mthmmy/activities/topic/TopicActivity.java
index 71afc53f..b5349d0b 100644
--- a/app/src/main/java/gr/thmmy/mthmmy/activities/topic/TopicActivity.java
+++ b/app/src/main/java/gr/thmmy/mthmmy/activities/topic/TopicActivity.java
@@ -798,58 +798,30 @@ public class TopicActivity extends BaseActivity implements TopicAdapter.OnPostFo
         });
     }
 
-
-
     /**This method sets a long click listener on the title of the topic. Once the
      * listener gets triggered, it copies the link url of the topic in the clipboard.
      * This method is getting called on the onCreate() of the TopicActivity*/
-    void setToolbarOnLongClickListener(String url)
-    {
-
-        toolbar.setOnLongClickListener(new View.OnLongClickListener() {
-            @Override
-            public boolean onLongClick(View view) {
-
-
-                //TRy to set the clipboard text.
-                try
-                {
-                    //Create a ClipboardManager.
-                    ClipboardManager clipboard = (ClipboardManager) getSystemService(CLIPBOARD_SERVICE);
-
-                    clipboard.setPrimaryClip(ClipData.newPlainText(BUNDLE_TOPIC_URL, url));
-
-                    //Make a toast to inform the user that the url was copied.
-                    Toast.makeText(
-                            TopicActivity.this,
-                            TopicActivity.this.getString(R.string.url_copied_msg),
-                            Toast.LENGTH_SHORT).show();
-                }
-
-
-                //Something happened. Probably the device does not support this.
-                catch (NullPointerException e)
-                {
-                    //Create a new dialog builder.
-                    AlertDialog.Builder builder = new AlertDialog.Builder(TopicActivity.this);
-
-                    //Set UP the alert dialog.
-                    builder.setMessage(getString(R.string.url_copy_does_not_work_msg));
-                    builder.setTitle("ERROR");
-                    builder.setPositiveButton("OK", new DialogInterface.OnClickListener() {
-                        @Override
-                        public void onClick(DialogInterface dialogInterface, int i) {
-                            dialogInterface.dismiss();
-                        }
-                    });
-
-                    //Create and show the alert dialog.
-                    AlertDialog dialog = builder.create();
-                    dialog.show();
-                }
-
-                return true;
+    void setToolbarOnLongClickListener(String url) {
+        toolbar.setOnLongClickListener(view -> {
+            //Try to set the clipboard text
+            try {
+                //Create a ClipboardManager
+                ClipboardManager clipboard = (ClipboardManager) getSystemService(CLIPBOARD_SERVICE);
+
+                clipboard.setPrimaryClip(ClipData.newPlainText(BUNDLE_TOPIC_URL, url));
+
+                //Make a toast to inform the user that the url was copied
+                Toast.makeText(
+                        TopicActivity.this,
+                        TopicActivity.this.getString(R.string.url_copied_msg),
+                        Toast.LENGTH_SHORT).show();
             }
+            //Something happened. Probably the device does not support this (report to Firebase)
+            catch (NullPointerException e) {
+                Timber.e(e, "Error while trying to copy topic's url.");
+            }
+
+            return true;
         });
     }
 }
\ No newline at end of file
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 42cce649..1593d8ae 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -231,6 +231,5 @@
     <!-- New topic activity -->
     <string name="new_topic_toolbar">New topic</string>
     <string name="create_topic">Create topic</string>
-    <string name="url_copied_msg">Url copied</string>
-    <string name="url_copy_does_not_work_msg">There was a problem copying the url. Probably your device does not support this functionality</string>
+    <string name="url_copied_msg">URL copied</string>
 </resources>